-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix travis #332
fix travis #332
Conversation
79b1c62
to
b299ca4
Compare
21e5d02
to
6e9025b
Compare
It's now failing with [info] [info] Compiling 3 Scala sources and 6 Java sources to /tmp/sbt_739e8f4/gen-android/target/scala-2.11/classes...
[info] [error] /tmp/sbt_739e8f4/gen-android/target/android/generated/source/org/scalaandroid/foo/TR.scala:47: type arguments [A] do not conform to method findViewById's type parameter bounds [V <: android.view.View]
[info] [error] final def findView[A](tr: TypedResource[A]): A = findViewById[A](tr.id)
[info] [error] ^
[info] [error] one error found and now it's failing with [info] [info] Compiling 3 Scala sources and 6 Java sources to /tmp/sbt_ced74bf/gen-android/target/scala-2.11/classes...
[error] [Fatal Error] :3:214: The value of attribute "name" associated with an element type "item" must not contain the '<' character.
[error] Could not read /usr/local/android-sdk-25.2.3/platform-tools/api/annotations.zip
[error] java.io.IOException: Could not parse XML from android/accounts/annotations.xml
[error] at com.android.tools.lint.ExternalAnnotationRepository$AnnotationsDatabase.initializePackage(ExternalAnnotationRepository.java:912) 😭 @pfn any idea what could be going wrong? |
2576bd3
to
978b67c
Compare
The former error is a android sdk selection issue. Probably needs to be at least android-24 or something; I'm not sure what the latter error is caused by. |
823e578
to
af16fe4
Compare
@pfn I think I fixed the first issues with |
3d06eb1
to
e12ea28
Compare
4b0cdc8
to
7f90f96
Compare
7f90f96
to
eb97845
Compare
https://stackoverflow.com/questions/28751111/invalid-abi-armeabi-v7a-for-the-selected-target-with-google-apis travis-ci/travis-ci#8188 https://stackoverflow.com/questions/40272884/running-android-emulator-with-noaudio-option-returns-qemu-system-i386-exe-au https://forums.adobe.com/thread/2538952 infinitered/ignite#1097
eb97845
to
5b1f703
Compare
Fix travis CI
# Conflicts: # resources/tr.scala.template
let me reiterate from #340 (comment)
|
@pfn we have a green build. can you please merge? |
@sideeffffect I love to see you pushing this forward, but I don't want to merge a PR without @pfn's approval. Could you perhaps kick off a fork instead? It seems like @pfn is not maintaining this project actively anymore. |
I'm trying to make some time to at least review and merge PRs if not
actively maintain; thanks for your patience.
…On Mon, Oct 7, 2019 at 2:25 PM Niklas Klein ***@***.***> wrote:
@sideeffffect <https://github.com/sideeffffect> I love to see you pushing
this forward, but I don't want to merge a PR without @pfn
<https://github.com/pfn>'s approval. Could you perhaps kick off a fork
instead? It seems like @pfn <https://github.com/pfn> is not maintaining
this project actively anymore.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#332?email_source=notifications&email_token=AAD5BRJ6QM2AX7IISYMKCHLQNOSOFA5CNFSM4GDA4A62YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEAR3MIY#issuecomment-539211299>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAD5BRM6RKNSIL7J4ZTPTITQNOSOFANCNFSM4GDA4A6Q>
.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is fine, however I would like for @pfn to make a final decision
Thanks for your work @sideeffffect |
* Fix merge manifests (scala-android#336) * Fix compiler error in generated code for platformAPI >= 26 * Update ManifestMerger to avoid exception when merging androidx WorkManager library * Upgrade to sbt 1 * fix travis (scala-android#332) * fix travis https://stackoverflow.com/questions/28751111/invalid-abi-armeabi-v7a-for-the-selected-target-with-google-apis travis-ci/travis-ci#8188 https://stackoverflow.com/questions/40272884/running-android-emulator-with-noaudio-option-returns-qemu-system-i386-exe-au https://forums.adobe.com/thread/2538952 infinitered/ignite#1097 * Fix travis CI * Travis badge 🎉 * Travis Cache fix * Travis Cache fix, 2 * Ignore .idea directory * Fix travis publishLocal tasks * Don't explicitly publish plugin on travis, scripted does this automatically * Undo last commit * Run scripted tests in parallel to improve travis build time * Update travis config for sbt 1.x * Quote TEST_COMMAND in travis config * Update gradle build tests to use sdk version 26 since travis installs that version * Small change to retrigger travis * Changed Typesafe Repo to https * upg .gitignore, upg sbt sbt.version=1.5.5 * upg sbt,cleanup * upg to scalaVersion := 2.12.19 , better err msg * cleaup * rm gradle * cleaup sbt * fix javac compile release,fmt * fix lint * fmt * refactor * try upg sbt * add ci * wip --------- Co-authored-by: Trudy Firestone <[email protected]> Co-authored-by: Jeff Boutotte <[email protected]> Co-authored-by: Ondra Pelech <[email protected]> Co-authored-by: jeffboutotte <[email protected]> Co-authored-by: Chris Wewerka <[email protected]>
https://stackoverflow.com/questions/28751111/invalid-abi-armeabi-v7a-for-the-selected-target-with-google-apis
https://stackoverflow.com/questions/40710849/sys-img-armeabi-v7a-android-23-is-missing-from-the-repository