cleanup base package.json + fix foundry gh action #60
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
For 2nd point checkout #43 (comment), although CLI generated
deployments/31337.json
dir but while pushing it to github the wholedeployments
dir was not tracked since31337.json
is only file indeployments
and was ignored too and this causes theyarn deploy
to fail in github actions (sincedeployments
dir is not present on github). Butyarn deploy
works nicely locally since its generated by CLI and then ignored with.gitignore
.To make
yarn deploy
work in foundry we need to make sure atleast emptydeployments
is present (something we could fix in scaffold-eth#867 or after in other PR) but for now I think this is fine.