Fractional store prices #246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkoenig10
suggested changes
Mar 24, 2017
.travis.yml
Outdated
| @@ -5,3 +5,4 @@ bundler_args: --without development staging production | |||
| sudo: false | |||
| before_script: | |||
| - bundle exec rake db:test:prepare | |||
| - bundle exec rake db:migrate RAILS_ENV=test | |||
There was a problem hiding this comment.
Change this workaround to do the proper thing for Rails 4.1+. http://stackoverflow.com/questions/17150529/why-am-i-asked-to-run-rake-dbmigrate-rails-env-test
db/seeds.rb
Outdated
| @@ -719,7 +719,7 @@ | |||
| # Store ------------------------------------------------------------------------- | |||
| puts 'Store' | |||
|
|
|||
| StoreItem.create({ name: '9 Volt Battery', price: 1, quantity: 1000}) | |||
| StoreItem.create({ name: '9 Volt Battery', price: 0.99, quantity: 1000}) | |||
There was a problem hiding this comment.
Don't change the store item prices in the seeds file. If you need to verify it works, change the objects in the test seeds. This file is currently used to persist long-term data (store prices, tool barcodes, etc.) so we don't want to make changes like this.
pkoenig10
approved these changes
Mar 25, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed database types to support fractional store prices