Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop overwriting forking config in extendConfig #893

Merged
merged 1 commit into from
Aug 29, 2024
Merged

Conversation

cgewecke
Copy link
Member

#891

The existing logic for extendConfig tries to clone the user's config and apply it to the resolved HH config after updating gas values, accidentally overwriting some necessary default fields in the forking object, which looks like this:

 forking: {
    url: 'https://opt-mainnet.g.alchemy.com/v2/....',
    enabled: true,
    httpHeaders: {},
    blockNumber: 123190000
  },

This isn't necessary, the config object is already seeded with user's values when extendConfig executes.

@cgewecke cgewecke merged commit df1df12 into master Aug 29, 2024
3 checks passed
@cgewecke cgewecke deleted the fix-viem-forking branch August 29, 2024 04:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant