-
Notifications
You must be signed in to change notification settings - Fork 269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to Truffle3, refactor CLI, add CLI unit tests, fix misc bugs #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l --save-dev solcover
Resolve inheritance issues
…modifying pre-existing
…previous README changes
… container memory limit
area
pushed a commit
that referenced
this pull request
Feb 27, 2019
truffle v5, leapdao/solidity-parser
cgewecke
added a commit
that referenced
this pull request
Mar 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR resolves a number of issues raised in Solcover since February 2017:
parse.js
)LibraryStatements
that's fixed and otherwise seems to work perfectly.PR makes structural changes to
runCoveredTests.js
(renamedexec.js
for brevity).npm install --save-dev solcover
possible. There are no guarantees that the target doesn't already include these dependencies and forking them seems to be the simplest way of scoping the assets correctly and making sure Solcover's modifications don't affect the other packages. Have added you with full admin privileges to a github org created to house them. You could fork them to Colony too though. Theethereumjs-vm
there contains the patch you wrote andtestrpc
has been altered to have a higher default transaction gas because it looked like some transactions were running out of gas.require
- again this lets npm figure out where it is / resolves problems raised if it's already one of the target's dependencies.--network coverage
(see README.md).solcover.js
config file - basically testrpc options and an arbitrary test command (see README.md)exec.js
.PR edits README with new instructions and adds links to some example repos/reports (haven't asked any of those people for permission to be exemplified - probably bad because their tests have coverage gaps, they might be saddened by this discovery, etc.)
One test file with an intentional syntax error isn't passing the Lint CI. I've added that to an eslintignore file to no avail. Additionally, two of the tests in the
cli
suite are explicitly disabled in the CI context because they launch their own testrpc instances and max out CI's container memory limit. They run locally though.