Skip to content

Commit

Permalink
react-dom is external peerDependency, just like react.
Browse files Browse the repository at this point in the history
fixes version conflicts, e.g. I got an error

  Uncaught TypeError: this.updater.enqueueCallback is not a function when using setState callback

because I use React 16.x and react-jsonschema-form bundled react-dom 15.x

See facebook/react#10320 (comment)
  • Loading branch information
sbusch committed Oct 26, 2018
1 parent b3fb5ae commit 99c5150
Showing 1 changed file with 7 additions and 0 deletions.
7 changes: 7 additions & 0 deletions webpack.config.dist.js
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,13 @@ module.exports = {
commonjs: "react",
commonjs2: "react",
amd: "react"
},
'react-dom': {
root: "ReactDOM",
commonjs2: 'react-dom',
commonjs: 'react-dom',
amd: 'react-dom',
umd: 'react-dom',
}
},
module: {
Expand Down

0 comments on commit 99c5150

Please sign in to comment.