Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Override abstract method onRewardedVideoCompleted() #273

Merged
merged 5 commits into from
Apr 16, 2018

Conversation

jeongjuwon
Copy link
Contributor

@jeongjuwon jeongjuwon commented Mar 22, 2018

While I was debugging in android, I'd got an error message that RNAdMobRewardedVideoAdModule is not abstract and does not override abstract method onRewardedVideoCompleted() in RewardedVideoAdListener
public class RNAdMobRewardedVideoAdModule extends ReactContextBaseJavaModule implements RewardedVideoAdListener

So I had implemented this method for android

screen shot 2018-03-23 at 1 23 55 pm

@rogerkerse
Copy link

Could someone merge it. It is a real issue with the library :/

@koenpunt
Copy link
Collaborator

koenpunt commented Apr 9, 2018

Thanks! Could it be that this method wasn't always required, or that it has been added in a later release?

@judemanutd
Copy link

judemanutd commented Apr 16, 2018

Confirmed working with the following specs

physical apple device running iOS 9.3.5
android emulator running 7.1.1

"react": "^16.3.1",
"react-native": "0.55.2",
"react-native-firebase": "4.0.3"

implementation "com.google.android.gms:play-services-base:15.0.0"
implementation 'com.google.firebase:firebase-core:15.0.0'
implementation "com.google.firebase:firebase-messaging:15.0.0"

Gradle plugin : 'com.android.tools.build:gradle:3.1.1'

Pods
 Firebase : 4.13.0
 Firebase Analytics : 4.2.0
 Firebase Core: 4.0.20
 Firebase InstanceID: 2.0.10
 Firebase Messaging : 2.2.0
 Google-Mobile-Ads-SDK : 7.3.0

This should definitely be merged into the existing repo to prevent any issues.
The following workaround causes an issue when using this library alongside React Native Firebase.
Implementing the changes in this PR, I was able to make both libraries work in the same app.

@koenpunt
Copy link
Collaborator

Thanks! I've updated the implementation to also cover iOS, and also the README has been updated.

@koenpunt koenpunt merged commit 900216a into sbugert:master Apr 16, 2018
@ravirupareliya
Copy link

Still why am i not able to get this code when i am using 2.0.0-beta.3 ?

@judemanutd
Copy link

@ravirupareliya it's because this has just been pushed to the master branch but hasn't been added to a new release version yet and I believe beta 4 is the latest version

@koenpunt
Copy link
Collaborator

2.0.0-beta.5 with all the latest changes has been pushed to npm, and can be installed using yarn add react-native-admob@next or npm install --save react-native-admob@next

@shobhitnpm
Copy link

Thanks @koenpunt, i works fine, just upgrade from 2.0.0-beta.4 to 2.0.0-beta.5

@wbrickner
Copy link

I've experienced the same issue installing from npm (more than 7 months later).
Is the npm version of the package not up to date with this git repo?

@jdgalani
Copy link

Still this issue remains same.
It is pushed to master right ?

@LeoUrushi
Copy link

Still have the same problem.

@e-vural
Copy link

e-vural commented Jun 3, 2019

Still have the same problem too

@rowheat02
Copy link

Still facing same problem. please someone fix this

@concuacon
Copy link

2.0.0-beta.5 with all the latest changes has been pushed to npm, and can be installed using yarn add react-native-admob@next or npm install --save react-native-admob@next

Still have the same problem, i use react native 0.60

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.