-
Notifications
You must be signed in to change notification settings - Fork 526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Override abstract method onRewardedVideoCompleted() #273
Conversation
Could someone merge it. It is a real issue with the library :/ |
Thanks! Could it be that this method wasn't always required, or that it has been added in a later release? |
Confirmed working with the following specs physical apple device running iOS 9.3.5
This should definitely be merged into the existing repo to prevent any issues. |
Thanks! I've updated the implementation to also cover iOS, and also the README has been updated. |
Still why am i not able to get this code when i am using |
@ravirupareliya it's because this has just been pushed to the master branch but hasn't been added to a new release version yet and I believe beta 4 is the latest version |
|
Thanks @koenpunt, i works fine, just upgrade from 2.0.0-beta.4 to 2.0.0-beta.5 |
I've experienced the same issue installing from npm (more than 7 months later). |
Still this issue remains same. |
Still have the same problem. |
Still have the same problem too |
Still facing same problem. please someone fix this |
Still have the same problem, i use react native 0.60 |
While I was debugging in android, I'd got an error message that RNAdMobRewardedVideoAdModule is not abstract and does not override abstract method onRewardedVideoCompleted() in RewardedVideoAdListener
public class RNAdMobRewardedVideoAdModule extends ReactContextBaseJavaModule implements RewardedVideoAdListener
So I had implemented this method for android