Fix: make sure requestPromise is only invoked once + crash when isLoaded() is called before requestAd() #241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Confirmed - we haven't seen these crashes in the last day and they occurred pretty frequently previously. |
|
hi, do you think to release this fix? |
|
Also would love to see this released, @koenpunt would you have the time to look into this? |
roy8119425
pushed a commit
to roy8119425/react-native-admob
that referenced
this pull request
Apr 14, 2021
…ded() is called before requestAd() (sbugert#241) * Fix: make sure we only invoke requestPromise once * Fix: check if mRewardedVideoAd is not null before calling .isLoaded() * remove newline
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #229
Give us a few days to test all of this in production - soon we can confirm that the crashes are gone.