🌱 [WIP] Runtimesdk/validate handlers on discovery #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Implemnent extensions api types, manifests and webhook Signed-off-by: killianmuldoon <[email protected]> * cleanup and nits
Signed-off-by: killianmuldoon <[email protected]>
Signed-off-by: killianmuldoon <[email protected]>
Signed-off-by: Stefan Büringer [email protected]
Signed-off-by: Stefan Büringer [email protected]
* Add client discovery calls to extension controller Signed-off-by: killianmuldoon <[email protected]> * update discovery flow Signed-off-by: killianmuldoon <[email protected]>
Signed-off-by: killianmuldoon <[email protected]> Co-authored-by: killianmuldoon <[email protected]>
Signed-off-by: killianmuldoon <[email protected]>
ykakarap
suggested changes
Apr 20, 2022
| @@ -197,14 +200,59 @@ func (r Reconciler) discoverExtension(ctx context.Context, extension *runtimev1. | |||
| // if any of these checks fails the response is invalid and an error is returned. Extensions with previously valid | |||
| // RuntimeExtension registrations are not removed from the registry or the object's status. | |||
| func validateRuntimeExtensionDiscovery(ext *runtimev1.Extension) error { | |||
| names := make(map[string]bool) | |||
| var errs []error | |||
| // TODO: Implement the same validation rules in the runtime SDK server side Discovery handler. | |||
| for _, runtimeExtension := range ext.Status.RuntimeExtensions { | |||
There was a problem hiding this comment.
How about also adding a validation rule to make sure that the hook is valid?
| } | ||
|
|
||
| // Timeout should be a positive integer and should be under 600 seconds (10 minutes) | ||
| if *runtimeExtension.TimeoutSeconds < 0 && *runtimeExtension.TimeoutSeconds > 600 { |
There was a problem hiding this comment.
10 minutes for maximum timeout seems too long. The admission webhooks in k8s allow a maximum timeout of 30s.
How about using the same for our maximum as well?
| // FIXME: How should we handle timeout is nil or zero? | ||
| // If TimeoutSeconds is not defined set to zero. | ||
| if runtimeExtension.TimeoutSeconds == nil { | ||
| runtimeExtension.TimeoutSeconds = pointer.Int32(0) |
There was a problem hiding this comment.
A 0s timeout means if the user does not set a timeout the network call will always timeout. The admission webhooks in k8s default to a timeout of 10s. We should also probably use the same timeout as default.
sbueringer
force-pushed
the
pr-runtime-sdk-experiments
branch
from
768739f to
9209b50
Compare
30 tasks
|
Closing in favor of #kubernetes-sigs#6578 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: killianmuldoon [email protected]
Add first round of validation rules on discovery of extensions in the extension controller.