Don't bomb if -Ypickle-java isn't present #836
Conversation
| val scalacOpts = config.currentSetup.options.scalacOptions | ||
| val pickleJava = { | ||
| if (isPickleJava && !scalacOpts.contains("-Ypickle-java")) | ||
| List("-Ypickle-java") | ||
| else Nil | ||
| } |
There was a problem hiding this comment.
I don't know if adding -Y flag forcefully would still make it a good default..
There was a problem hiding this comment.
Hmm... Yeah. Just drop the assert, then? WDYT?
There was a problem hiding this comment.
This would mess up pipelining. I think the solution is to actually solve the mixed Scala/Java compilation, and let the build tools configure the flags.
There was a problem hiding this comment.
Why and how would it mess it up? It's an assertion, so removing it can't actively mess anything up.
There was a problem hiding this comment.
I don't disagree with eventually finding a solution for pipelining in mixed projects, but we can drop as it breaks your example.
There was a problem hiding this comment.
When a build tool (currently scripted) correctly hooks up the pipelined tasks, not passing -Ypickle-java would create mysterious error saying the symbols (defined in upstream Java subproject) are not found.
There was a problem hiding this comment.
Yeah, but it's not an outlier: there's about a billion ways you can set up pipelining wrong.
dwijnand
force-pushed
the
Ypickle-java-yourself
branch
from
3c45c7f
to
6f79758
Compare
dwijnand
changed the title
|
#843 disables pipelining but tests everything with it, which works for me. |
No description provided.