[Do not merge] Adapt Zinc to use the new LibraryManagement API #335
Conversation
|
dbuild has checked the following projects against Scala 2.12:
❌ The result is: FAILED |
project/Dependencies.scala
Outdated
| @@ -10,7 +10,7 @@ object Dependencies { | |||
|
|
|||
| private val ioVersion = "1.0.0-M12" | |||
| private val utilVersion = "1.0.0-M25" | |||
| private val lmVersion = "1.0.0-X16" | |||
| private val lmVersion = "1.0.0-SNAPSHOT" | |||
There was a problem hiding this comment.
Can we depend on a stable version?
There was a problem hiding this comment.
That's the plan once the new library management API is merged and released.
| dependencies, | ||
| None, | ||
| ZincLMHelper.DefaultConfigurations) | ||
| libraryManagement.moduleDescriptor(wrapper, dependencies, None) |
There was a problem hiding this comment.
Component is no longer part of the configurations out of the box, so that might needs adjustment.
| def addSbtLm(p: Project): Project = addSbtModule(p, sbtLmPath, "lm", libraryManagement) | ||
| def addSbtLmCore(p: Project): Project = addSbtModule(p, sbtLmPath, "lmCore", libraryManagementCore) | ||
| def addSbtLmIvy(p: Project): Project = addSbtModule(p, sbtLmPath, "lmIvy", libraryManagementIvy) | ||
| def addSbtLmIvyTest(p: Project): Project = addSbtModule(p, sbtLmPath, "lmIvy", libraryManagementIvy, Some(Test)) |
|
Should we rename the |
Yes. Let's do it. |
|
Done |
|
When is the new LM api gonna be released? This is blocking adding a new method to the public API. |
|
LM API has been merged. I am now starting to merge PRs for Zinc locally to make sure they compile. |
|
Superseded by #366. |
Depends on sbt/librarymanagement#124.