Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing invalidation when deleting source file #1268

Closed
lrytz opened this issue Oct 12, 2023 · 0 comments · Fixed by #1287
Closed

Missing invalidation when deleting source file #1268

lrytz opened this issue Oct 12, 2023 · 0 comments · Fixed by #1287

Comments

@lrytz
Copy link
Contributor

lrytz commented Oct 12, 2023

Zinc misses an invalidation when deleting a source file.

The issue shows up with an existing test case in the zinc repo: https://github.com/sbt/zinc/tree/develop/zinc/src/sbt-test/source-dependencies/empty-package.

For some reason, the test passes when it runs with zinc's scripted implementation. It fails when reproducing it in a small sbt project (make sure to set incOptions := incOptions.value.withRecompileAllFraction(1.0)), or when running it with sbt's scripted implementation (used in scala/scala).

To reproduce it using scala/scala:

Output from the scala/scala test: https://gist.github.com/lrytz/61930adc6ed4f7d0648bbc1abf3b0bef

For reference, output when running the test in the zinc repo: https://gist.github.com/lrytz/e42076ecadc49c770465f97c12a0602b

The issue reproduces with 2.13.12, older 2.13 releases, and also with 2.12.18 and 3.3.1. I tested 2.13.12 with sbt 1.9.6 (where it uses the binary bridge) and 1.9.4 (where it uses the bridge compiled from zinc sources), it happens in both cases.

Transfered from scala/bug#12887 - I was first thinking this is a new issue in scala/scala, but it is in fact an old issue in zinc (possibly the compiler bridge).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant