Fix code rendering on Windows via updating Inconsolata font
#1269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Friendseeker
changed the title
Inconsolata fontInconsolata font to fix code rendering on Windows
Friendseeker
changed the title
Inconsolata font to fix code rendering on WindowsInconsolata font
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Rendering of certain characters (e.g.
k) underInconsolatafont is broken on Windows.Fix
Replace
Inconsolatafont file with the latest variable font file from https://fonts.google.com/specimen/InconsolataTesting the PR
Ran
mdbook serveto build website locally.(Same Machine, Same Browser, screenshots taken from 2 tabs on the same Browser instance)
Before
After
Closes #1268