Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Hugo 0.20 version check issue #96

Merged
merged 3 commits into from
Apr 11, 2017
Merged

Fix Hugo 0.20 version check issue #96

merged 3 commits into from
Apr 11, 2017

Conversation

vshalts
Copy link
Contributor

@vshalts vshalts commented Apr 11, 2017

Hi,

Starting from Hugo 0.20 (current) old regexp used to extract version is broken. I suggest to change version extraction a bit, so it will include all digits up to next non digit symbol. This will fix issue. Probably make sense to fix .travis.yml too to install latest Hugo during testing, but I don't have experience with travis and I haven't touched config file.

@jonas
Copy link
Member

jonas commented Apr 11, 2017

Changing the installed version should be a matter of running s/0.16/0.20/ on the file.

@vshalts
Copy link
Contributor Author

vshalts commented Apr 11, 2017

Almost, tgz now absent and tar.gz should be used instead. Added changes for Travis.

@jonas
Copy link
Member

jonas commented Apr 11, 2017

It looks like they might have changed the packaging. I will take a look later today

@vshalts
Copy link
Contributor Author

vshalts commented Apr 11, 2017

Yes, they are. Looks like I fixed it at last. Need to learn how to test Travis locally.

@jonas
Copy link
Member

jonas commented Apr 11, 2017

Awesome, thanks for also fixing Travis. I usually just copy paste the lines from the file.

@jonas jonas merged commit 8aeb412 into sbt:develop Apr 11, 2017
@jonas jonas added this to the 1.2.1 milestone Apr 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants