Allow general search and replace in Preprocess #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ennru
reviewed
Dec 19, 2018
src/main/scala/com/typesafe/sbt/site/preprocess/PreprocessKeys.scala
Outdated
Show resolved
Hide resolved
….scala Co-Authored-By: 2m <[email protected]>
|
Would be good to exercise this feature in scripted tests. |
|
Added scripted test and documentation. Needed to upgrade paradox theme to be able to generate project documentation locally. |
ennru
approved these changes
May 17, 2019
There was a problem hiding this comment.
LGTM. Great feature.
You could maybe add the example for patching Scaladoc's .scala.java to .java in the docs?
Even though it will be fixed in 2.12.9 and 2.13.0 scala/scala#7532 scala/scala#7559
|
Pushed a scripted test with a useful preprocessing rule. |
|
This does not fail locally for me. Investigating... |
so the output of the doc task could be used by makeSite
|
Locally it worked, because I had files in the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces
preprocessRuleswhich allows general search and replace by regex inPreprocessMakes it possible to fix akka/alpakka#1378