add asciidoctor-diagram support #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonas
approved these changes
May 7, 2018
| @@ -6,7 +6,7 @@ name := "sbt-site" | |||
|
|
|||
| organization := "com.typesafe.sbt" | |||
|
|
|||
| version := "1.3.2" | |||
| version := "1.3.3-SNAPSHOT" | |||
build.sbt
Outdated
| @@ -28,7 +28,8 @@ libraryDependencies ++= Seq( | |||
| "org.foundweekends" %% "pamflet-library" % "0.7.1", | |||
| "org.yaml" % "snakeyaml" % "1.13", | |||
| "com.typesafe" % "config" % "1.2.1", // Last version to support Java 1.6 | |||
| "org.asciidoctor" % "asciidoctorj" % "1.5.4" | |||
| "org.asciidoctor" % "asciidoctorj" % "1.5.4", | |||
| "org.asciidoctor" % "asciidoctorj-diagram" % "1.5.4.1" | |||
There was a problem hiding this comment.
Why is this using a different version?
There was a problem hiding this comment.
The different version wasn't intentional.
Should I downgrade the asciidoctorj-diagram dependency to 1.5.4, or upgrade the asciidoctorj dependecy to 1.5.4.1?
1.5.4.1 is a bugfix release https://github.com/asciidoctor/asciidoctorj/releases/tag/v1.5.4.1
There was a problem hiding this comment.
If it is a bugfix release then I suggest we go ahead and upgrade.
|
Fixes #76 it seems |
|
Thanks again. |
|
@oalyman Any idea when this version 1.3.3 gets released ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables the usage of https://asciidoctor.org/docs/asciidoctor-diagram/