Laika site support for sbt 1.0 #125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Scope the Laika setting to laikaSite and remove override for makeSite to simply call laikaSite in order to derive the mappings.
|
@rhpvorderman I've rebased your PR and added a few fixes. It would be great if you could take a look since I have never used Laika nor the sbt-site plugin. I've changed the sbt 1.x version to scope the Laika settings to |
Ensures that the LaikaSite plugin automatically loads the LaikaPlugin when enabled. Also reenabled the excludeFilter.
|
Yay, it’s green. Once I get a confirmation I’ll be happy to cut a release. |
|
Also ran it on our documentation test suite and it works! |
3 tasks
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #121 with improvements to the sbt 1.x version of the plugin and the documentation.