Support for absolute paths in classpath #882
Conversation
Do not prefix with $lib_dir when an absolute path is added to the classpath
|
Hi @hayssams, Thank you for your contribution! We really value the time you've taken to put this together. Before we proceed with reviewing this pull request, please sign the Lightbend Contributors License Agreement: |
|
Thanks for your pull requests. Can you explain the reasons and use cases? In order to accept the pull request we would also need a few things
|
|
When building a package you sometimes need to add in the classpath, an absolute path in your package like a docker volume path or any external path. You are right documentation and tests are missing and I have to add them asap. |
|
Still need to get used to the new github review tools ;) If you need any help on writing tests and documentation you can read the Developer Guide or ask here. |
|
@typesafehub-validator CLA already signed |
|
Hi @muuki88 To add an absolute path to the app classpath just set it in the scriptClasspath Key as follows : |
| @@ -11,9 +11,10 @@ object JavaAppBatScript { | |||
|
|
|||
| def makeWindowsRelativeClasspathDefine(cp: Seq[String]): String = { | |||
| def cleanPath(path: String): String = path.replaceAll("/", "\\\\") | |||
| def isAbsolute(path: String): Boolean = path.length > "c:\\".length && Character.isLetter(path(0)) && path(1) == ':' | |||
There was a problem hiding this comment.
I'm a bit confused about the "c:\\".lengthdefinition. It looks like putting documentation into the source code.
If you have to check for a path longer than 4 characters do so explicitly and add a small comment for what reason. At first I thought you were checking if the path starts with `c:\`` ;)
There was a problem hiding this comment.
ok will do it in a few minutes
| @@ -0,0 +1,21 @@ | |||
| enablePlugins(JavaAppPackaging) | |||
There was a problem hiding this comment.
Test looks good. However can you split this into two tests?
The bash one goes into sbt-test/bash and ( I know this is confusing :( ) into sbt-test/windows
|
Awesome. Thanks :) |
Do not prefix with $lib_dir when an absolute path is added to the
classpath