Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update start-template for systemd #629

Merged
merged 1 commit into from
Jul 28, 2015
Merged

Conversation

kononencheg
Copy link
Contributor

sighup for reload

sighup for reload
@kardapoltsev
Copy link
Member

Nice addition! It would be great if you add the same feature to other system loaders (SystemV and Upstart) (:

@muuki88 muuki88 added the universal Zip, tar.gz, tgz and bash issues label Jul 28, 2015
@muuki88
Copy link
Contributor

muuki88 commented Jul 28, 2015

@kardapoltsev would this be simple to do? For upstart maybe, but for SystemV I think this is though :p
For me this looks good to merge. Any further improvements would be awesome, but not required IMO.

And I'm not 100% sure what this addition does xD

@kardapoltsev
Copy link
Member

And I'm not 100% sure what this addition does xD

It only sends SIGHUP (1) signal to application.
Additions would be great but definitely isn't required. For SystemV it could look like

 reload)
    status_of_proc -p "$PIDFILE" "$RUN_CMD" ${{app_name}} > /dev/null || /bin/kill -HUP "${PIDFILE}"
    ;;

I didn't test it.

@kardapoltsev
Copy link
Member

@kononencheg do you plan to add smth? If not it's fine to merge it as is IMHO.

@kononencheg
Copy link
Contributor Author

@kardapoltsev no, that's all.

kardapoltsev added a commit that referenced this pull request Jul 28, 2015
Update start-template for systemd
@kardapoltsev kardapoltsev merged commit 2bfc959 into sbt:master Jul 28, 2015
@kardapoltsev
Copy link
Member

Thanks, this is a nice feature for some apps!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
universal Zip, tar.gz, tgz and bash issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants