-
Notifications
You must be signed in to change notification settings - Fork 444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wait for process to stop or timeout in systemv init script #462
Conversation
Hi @dhardy92, Thank you for your contribution! We really value the time you've taken to put this together. Before we proceed with reviewing this pull request, please sign the Typesafe Contributors License Agreement: |
LGTM. On which system did you test this? |
May be it'll be better to specify timeouts in configs? For some applications it could take long time for proper shutdown. |
@muuki88 I just signed it :
|
@kardapoltsev I just push a proposition to use variables but as I don't know Scala (sysop here 😄 ) : BTW tests pass |
LGTM. Thanks! Lets wait for travis (: |
Ah, good catch @kardapoltsev . @dhardy92 could you squash the commits? I'll try to backport this to |
e5d9da4
to
5c5785b
Compare
squashed |
awesome. Thanks :) |
wait for process to stop or timeout in systemv init script
start-stop-dameons does not wait for service to stop before returning.
This may results in error on upgrade of the package trying to start the service while old version is still shutting down.