Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix order of docker commands #293

Merged
merged 1 commit into from
Jul 14, 2014
Merged

Conversation

rfranco
Copy link
Contributor

@rfranco rfranco commented Jul 14, 2014

In Dockerfile the FROM commad should be alway the first
but when add dockerExposedPorts or dockerExposedVolumes those are the first line in the file.

[info] Step 0 : EXPOSE 9000
[error] 2014/07/14 12:46:23 Please provide a source image with `from` prior to commit
[trace] Stack trace suppressed: run last docker:publishLocal for the full output.
[error] (docker:publishLocal) Nonzero exit value: 1

@muuki88 muuki88 added the docker label Jul 14, 2014
@muuki88
Copy link
Contributor

muuki88 commented Jul 14, 2014

LGTM. Did you run the tests on your local machine with

scripted docker/*

?
cc @fiadliel

@rfranco
Copy link
Contributor Author

rfranco commented Jul 14, 2014

Yes, i did

Running docker / simple-docker
Running docker / staging
Running docker / volumes
[success] Total time: 65 s, completed Jul 14, 2014 1:26:07 PM

muuki88 added a commit that referenced this pull request Jul 14, 2014
@muuki88 muuki88 merged commit e75f1d6 into sbt:master Jul 14, 2014
@muuki88
Copy link
Contributor

muuki88 commented Jul 14, 2014

Awesome, thanks.

@muuki88 muuki88 added this to the 0.8.0 - windows services milestone Jul 14, 2014
@fiadliel
Copy link
Contributor

👍 Some final cleanup bit me here, sorry...

@rfranco rfranco deleted the fix-docker-commands branch October 10, 2019 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants