-
Notifications
You must be signed in to change notification settings - Fork 444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for changelog and .changes file generation #268
Conversation
You could run tests with
|
case x => sys.error("Failure packaging debian file. Exit code: " + x) | ||
} | ||
val files = pkgdir / Names.Debian / Names.Files | ||
IO.writeLines(files, List(s"$archive $section $priority")) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently we still support scala 2.9.x , so the string interpolation must be replaced with string concatenation :(
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It may be time to drop that..... WDYT - our 1.0 on sbt 0.13.x + 1.0?
This is a cool addition. +1 for adjusting the docs. So, if I understand correctly this addition must be used like this
so it generates the changes file and then the package? |
No, it is only necessary to run debian:genChanges: it will generate both the .deb and the .changes. Actually, the changes file contains a checksum of the .deb so we are obliged to build the package first. |
… a separated "debian" directory
@@ -252,6 +261,23 @@ trait DebianPlugin extends Plugin with linux.LinuxPlugin { | |||
}, | |||
lintian <<= packageBin map { file => | |||
Process(Seq("lintian", "-c", "-v", file.getName), Some(file.getParentFile)).! | |||
}, | |||
genChanges <<= (packageBin, target, debianChangelog, name, version, packageArchitecture) map { (_, tdir, changelog, name, version, arch) => |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This task should be added to the packagedArtifacts so when you publish using ivy, the changelog comes too.
So I fixed the failing tests, removed all string interpolations and added the genChanges target to the packagedArtifacts. |
LGTM. +1 for the extra test. I'm a bit confused where the |
The |
Tests are running on my machine as well. Nice work. |
Support for changelog and .changes file generation
Hello,
This pull request aims at creating a .changes file associated to the debian package, which is necessary to upload the package on a mirror. So I added a changelog key and a genChanges task.
It was necessary to make minor modifications to the packageBin task to conform to debian standards (especially the name of the package).
Unfortunately I could not figure out how to run the tests, so I hope I did not introduce any regression.