Exclude non-required artifacts from the lib folder #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -149,7 +148,13 @@ object JavaAppPackaging { | |||
| for { | |||
| p <- previous | |||
| n <- next | |||
| } yield (p ++ n).distinct | |||
| } yield (p ++ n) | |||
| .distinct | |||
There was a problem hiding this comment.
I know this isn't your normal project, but I tend to prefer either parenthesis or a () around this kinds of things, for clarity:
(for {
...
yield ...).distinct.filterNot { f =>
...
}Yeah, I prefer variable names on the same line as the closure. Also, I believe you can grab this info off the attributes (i.e. the Artifact has a type of src/jar/doc/pom. I think). This works for now. If I have a chance to dig in I while.
|
This looks great, but there's a merge conflict (gitignore?) Can you resubmit? thanks. |
…. The presence of the pom.xml would cause the project's jar file to be overwritten given that the xml and the jar have the same name sans extension. The javadoc and source are not required for running the project (which I presume is the motivation behind determining these artefacts).
|
Merge conflicts fixed and pushed. |
| @@ -1,3 +1,11 @@ | |||
| project/project | |||
There was a problem hiding this comment.
huh, who added project/project? DOH!
|
Thanks @huntc. LGTM. |
jsuereth
added a commit
that referenced
this pull request
Sep 3, 2013
Exclude non-required artifacts from the lib folder
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR filters out .pom, sources and javadoc from projectDependencyArtifacts. The presence of the pom.xml would cause the project's jar file to be overwritten given that the xml and the jar have the same name sans extension. The javadoc and source are not required for running the project (which I presume is the motivation behind determining these artefacts).
This issue relates to playframework/playframework#1564