-
Notifications
You must be signed in to change notification settings - Fork 444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Debian script header #231
Conversation
Hi @dax, Thank you for your contribution! We really value the time you've taken to put this together. Before we proceed with reviewing this pull request, please sign the Typesafe Contributors License Agreement: |
Thanks :) For some of the scripts the header will be redundant, but that's okay has |
I got the error on a Debian squeeze. |
May be we should add something like |
This would be even better |
Ok, I will do it. |
@dax would you reimplement your PR? If not then I will fix. And thanks for your effort anyway! |
I have updated my PR. Tell me if this is what you expected. |
LGTM except one small note. val userGroupAdd = headerScript ++ Seq(
TemplateWriter.generateScript(DebianPlugin.postinstGroupaddTemplateSource, replacements),
TemplateWriter.generateScript(DebianPlugin.postinstUseraddTemplateSource, replacements)) May be it'll be better to handle postinst similar to other scripts like prependAndFixPerms(postinst, headerScript, LinuxFileMetaData()) |
Hi @dax, Thank you for your contribution! We really value the time you've taken to put this together. Before we proceed with reviewing this pull request, please sign the Typesafe Contributors License Agreement: |
Ok, I fixed it. |
LGTM. Works for Ubuntu 13.04. @kardapoltsev did you test it, too? If so, you can merge this. |
@dax, thanks! |
And I've added tests for scripts header |
Without the shell header, Debian package installation fails with
Exec format error