-
Notifications
You must be signed in to change notification settings - Fork 444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change all references to macOS #1301
Conversation
Hehe, there's a branch protection status check rule on |
Change all references to macOS (MacOS X, MacOSX, OS X, OSX, macOSx, macosx, osx). That leaves the `TRAVIS_OS_NAME` env var, which seems to only supports the variant 'osx', as far as I can tell. It also leaves the `packageOsxDmg`/`package-osx-dmg` task key, that is both public binary API and public semantic API, as keys are global in sbt's build state - so I just left it as is for now.
For the record, The AppVeyor failure seems unrelated to this?
|
Thanks for your pull request 🤗
Where did you see this 😮 I haven't found anything in the project settings. |
Yeah. The appveyor build is broken since a few days / weeks. I haven't had the time yet to look into it. |
https://github.com/sbt/sbt-native-packager/settings/branch_protection_rules/406757 |
Change all references to macOS (MacOS X, MacOSX, OS X, OSX, macOSx, macosx, osx).
That leaves the
TRAVIS_OS_NAME
env var, which seems to only supportsthe variant 'osx', as far as I can tell.
It also leaves the
packageOsxDmg
/package-osx-dmg
task key, that isboth public binary API and public semantic API, as keys are global in
sbt's build state - so I just left it as is for now.