Run chmod +x explicitly in stage0 #1201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
muuki88
approved these changes
Feb 11, 2019
eed3si9n
commented
Feb 11, 2019
| * Gives +x permission to users and groups. | ||
| */ | ||
| case object UserGroupPlusExecute extends DockerChmodType { | ||
| def argument: String = "u=+x,g=+x" |
There was a problem hiding this comment.
This is a mistake. It should be u+x,g+x.
Using sbt-native-packager 1.3.17 with OpenShift, I still ran into some permission issues and needed to call chmod +x explicitly in the container. This will emit chmod +x for all bash scripts that was generated.
|
@muuki88 Fixed a bug that the tests caught, and also updated the docs. |
muuki88
approved these changes
Feb 12, 2019
muuki88
reviewed
Feb 28, 2019
| @@ -108,6 +108,16 @@ object DockerPlugin extends AutoPlugin { | |||
| }, | |||
| dockerRmiCommand := dockerExecCommand.value ++ Seq("rmi"), | |||
| dockerBuildCommand := dockerExecCommand.value ++ Seq("build") ++ dockerBuildOptions.value ++ Seq("."), | |||
| dockerAdditionalPermissions := { | |||
| val scripts = makeBashScripts.value | |||
There was a problem hiding this comment.
I overlooked that. This causes a circular dependency between JavaAppPackaging and the DockerPlugin, which produces a bug reported in #1205
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is on top of #1200
Using sbt-native-packager 1.3.17 with OpenShift, I still ran into some permission issues and needed to call chmod +x explicitly in the container. This will emit chmod +x for all bash scripts that was generated.