Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve main class detection #1055

Merged
merged 2 commits into from
Oct 29, 2017
Merged

Improve main class detection #1055

merged 2 commits into from
Oct 29, 2017

Conversation

dwickern
Copy link
Collaborator

Fixes an issue where the main class is not discovered because it's located in a different jar on the classpath. For example:

> show mainClass
[info] Some(play.core.server.ProdServerStart)
> show discoveredMainClasses
[info] * com.acme.CustomMainClass

This matches the first case, and consequently the discovered main class is ignored

      case Some(main) if discoveredMainClasses.size == 1 => SingleMain(main)

@muuki88 muuki88 added the universal Zip, tar.gz, tgz and bash issues label Oct 27, 2017
muuki88
muuki88 approved these changes Oct 29, 2017
View reviewed changes
Copy link
Contributor

@muuki88 muuki88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! And thanks for the unit tests on this one.

@muuki88 muuki88 merged commit f9a2aac into sbt:master Oct 29, 2017
@dwickern dwickern deleted the main-class-detection branch November 2, 2017 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@muuki88 muuki88 muuki88 approved these changes

Assignees
No one assigned
Labels
universal Zip, tar.gz, tgz and bash issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dwickern @muuki88