Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

application does not receive SIGINT signal when using ash. #707

Closed
yanns opened this issue Dec 1, 2015 · 6 comments
Closed

application does not receive SIGINT signal when using ash. #707

yanns opened this issue Dec 1, 2015 · 6 comments

Comments

@yanns
Copy link
Contributor

yanns commented Dec 1, 2015

When using bash, a kill of one application sends the SIGINT to it, triggering the shutdown hooks.
When using ash with enablePlugins(AshScriptPlugin), the application does not receive the SIGINT. It has no way to cleanly shutdown. Only the SIGTERM kills the application, without triggering the shutdown hooks.

Docker for example send the SIGINT signal, waits 10 s, and then sends the SIGTERM signal. Packaging the application with enablePlugins(AshScriptPlugin) makes each shutdown waiting 10s.

yanns added a commit to yanns/cloudqueues-simulator that referenced this issue Dec 1, 2015
@muuki88
Copy link
Contributor

muuki88 commented Dec 1, 2015

I'm not familiar with ash. Feel free to provide a PR to fix this :)

@NeQuissimus
Copy link
Contributor

I am going to send a PR for this, I actually worked around this for our images (we need the SIGINT for Kubernetes). I will try to wrap it into a proper fix.

@NeQuissimus
Copy link
Contributor

Actually, this is already fixed in > 1.1.5.

The issue was that the ash script somehow had its exec stripped from the bottom of the file.
With 1.2.0-M8 that issue no longer exists.

For reference, I previously worked around this by providing my custom script as suggested in the Scaladoc for AshScriptPlugin.

@muuki88
Copy link
Contributor

muuki88 commented Apr 17, 2017

Thanks @NeQuissimus 😃

@muuki88 muuki88 closed this as completed Apr 17, 2017
@NeQuissimus
Copy link
Contributor

@muuki88 Just going through the docker-labelled tickets to see what could bite me in the future since my company is using sbt-native-packager for Docker now :D

@muuki88
Copy link
Contributor

muuki88 commented Apr 17, 2017

Smart move 😎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants