-
Notifications
You must be signed in to change notification settings - Fork 444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
With JDKNativePackager, src/deploy is not on the classpath in the build.xml #644
Comments
@muuki88 I labeled this as a bug, as I thought it was doing that. Hope to work on this soon. |
@metasim sure! Looking forward to your pr :) |
@DaveDeCaprio Before I submit the pull request, would you be open to giving the fix a spin? It's on my fork, on branch https://github.com/metasim/sbt-native-packager/tree/issue/644 (Let me know if you need pointers on the trick to use a plugin via a Git repo URI.) |
Be happy to try it, but yes I need pointers on how to use a plugin from a repo url. Dave |
@DaveDeCaprio In your
use this:
SBT will check out the repo in a temp directory, compile it, and load it as a plugin. It's a pretty sweet feature. |
@DaveDeCaprio @muuki88 Also note I added a new key |
That syntax isn't working for me. I get error: I'm on windows (testing a windows installer). I'm trying to just build manually and use the plugin that way |
This is working for me great with this version. Go ahead and issue the pull request. |
@DaveDeCaprio Very much appreciate you testing it for us.! |
Fix for #644 (`src/deploy` in Ant classpath).
PR merged via #645. |
I am using the JDKNativePackager - it works quite well by the way. The issues I am posting are minor and are really just about automating the process. In general, it works great.
By defaults, the src/deploy directory from the project is not included in the build.xml file. The application icon file works, but if you try to put other things in there they aren't included in the build.
Specifically, I was using the Inno Setup on windows and wanted to include license file and separate bmp for the setup program. If I manually edit the generated buil.xml to include src/deploy in the classpath it all works.
The text was updated successfully, but these errors were encountered: