Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Version '1'? New SBT capability? #1356

Closed
ScalaWilliam opened this issue Aug 1, 2020 · 1 comment · Fixed by #1357
Closed

Version '1'? New SBT capability? #1356

ScalaWilliam opened this issue Aug 1, 2020 · 1 comment · Fixed by #1357

Comments

@ScalaWilliam
Copy link
Contributor

ScalaWilliam commented Aug 1, 2020 •
edited
Loading

Hi @muuki88 ,

Just noticed this in the README:

image

Surprisingly it does work but I am uncertain if this makes sense. Is there some new syntax that allows you to map from version "1" to latest "1.7.4"? If this looks wrong, I am happy to make a PR to fix that.

Original commit to do this change is here d38caf6
@muuki88
Copy link
Contributor

muuki88 commented Aug 1, 2020

Hi @ScalaWilliam 😊

Thanks for noticing. There must be something wrong in the code updating this. I'm very happy to merge a pull request 🥰

ScalaWilliam added a commit that referenced this issue Aug 1, 2020
@ScalaWilliam
Restore version in the README to 1.7.4
dc0b356 
Closes #1356
@ScalaWilliam ScalaWilliam mentioned this issue Aug 1, 2020
Merged
muuki88 pushed a commit that referenced this issue Aug 2, 2020
@ScalaWilliam
Restore version in the README to 1.7.4 (#1357)
988d6c6 
Closes #1356
@muuki88 muuki88 mentioned this issue Aug 2, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Restore version in the README to 1.7.4 sbt/sbt-native-packager
2 participants
@muuki88 @ScalaWilliam