Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JlinkPlugin: support multi-release dependencies #1243

Closed
nigredo-tori opened this issue Jul 9, 2019 · 1 comment · Fixed by #1244
Closed

JlinkPlugin: support multi-release dependencies #1243

nigredo-tori opened this issue Jul 9, 2019 · 1 comment · Fixed by #1244
Labels
documentation Documentation should be extended or updated jlink

Comments

@nigredo-tori
Copy link
Collaborator

For multi-release dependency JARs jdeps needs a --multi-release flag with the required JVM version. We can get this from the same Java toolchain - no need to expose it as a setting or to check for multiple versions. The whole point of the plugin is that we know what JVM version the application will be using.

This issue is for documentation purposes only, I'll try and do this myself tomorrow.
@muuki88 muuki88 added feature request jlink documentation Documentation should be extended or updated and removed feature request labels Jul 9, 2019
@nigredo-tori
Copy link
Collaborator Author

Additionally, it seems that at least some jdeps errors are not showing in the SBT log, since jdeps writes them to stdout.

nigredo-tori added a commit to nigredo-tori/sbt-native-packager that referenced this issue Jul 10, 2019
@nigredo-tori
Fix error logging in JlinkPlugin (sbt#1243)
4f868fb
nigredo-tori added a commit to nigredo-tori/sbt-native-packager that referenced this issue Jul 10, 2019
@nigredo-tori
Add a test case for multi-release dependency (sbt#1243)
6e9fab4
nigredo-tori added a commit to nigredo-tori/sbt-native-packager that referenced this issue Jul 10, 2019
@nigredo-tori
Add support for multi-release dependencies (sbt#1243)
a6943af
nigredo-tori added a commit to nigredo-tori/sbt-native-packager that referenced this issue Jul 10, 2019
@nigredo-tori
Add support for multi-release dependencies (sbt#1243)
0caa035
nigredo-tori added a commit to nigredo-tori/sbt-native-packager that referenced this issue Jul 10, 2019
@nigredo-tori
Add support for multi-release dependencies (sbt#1243)
fb083e3
@nigredo-tori nigredo-tori mentioned this issue Jul 10, 2019
Merged
muuki88 pushed a commit that referenced this issue Jul 10, 2019
@nigredo-tori @muuki88
JlinkPlugin: support multi-release dependencies (#1244)
6e6eca0 
* Fix error logging in JlinkPlugin (#1243)

* Add a test case for multi-release dependency (#1243)

* Add support for multi-release dependencies (#1243)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation Documentation should be extended or updated jlink
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

JlinkPlugin: support multi-release dependencies nigredo-tori/sbt-native-packager
2 participants
@muuki88 @nigredo-tori