Add some notes for later.

sbt · Nov 17, 2013 · b8078a3 · b8078a3
1 parent b9eef32
commit b8078a3
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 0 deletions.
diff --git a/src/main/scala/com/typesafe/sbt/packager/universal/ZipHelper.scala b/src/main/scala/com/typesafe/sbt/packager/universal/ZipHelper.scala
@@ -40,6 +40,9 @@ object ZipHelper {
     }
 
   /** Creates a zip file attempting to give files the appropriate unix permissions using Java 6 APIs.
+   * Note: This is known to have some odd issues on MacOSX whereby executable permissions
+   * are not actually discovered, even though the Info-Zip headers exist and work on
+   * many variants of linux.  Yay Apple.
    * @param sources   The files to include in the zip file.
    * @param outputZip The location of the output file.
    */

diff --git a/src/main/scala/com/typesafe/sbt/packager/windows/WixHelper.scala b/src/main/scala/com/typesafe/sbt/packager/windows/WixHelper.scala
@@ -127,6 +127,11 @@ object WixHelper {
               </Component>
             </DirectoryRef>
             ComponentInfo(id, xml)
+      // TODO - To have shortcuts, you MUST put something in the registry.  Here,
+      // We should have shortcuts actually provide us with what they want in the registry,
+      // rather than forcing it to be something.
+      // Also, we need some mechanism to ensure the start menu folder is removed in the event
+      // that we remove all menu items.
       case AddShortCuts(targets, workingDir) =>
         val id = cleanStringForId("shortcut_" + makeGUID).takeRight(67)  // Room for "_SC"
         val xml =