Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use allModuleReports from sbt 1.9.5 #88

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mdedetrich
Copy link
Contributor

Self explanatory

@@ -10,6 +10,7 @@ name := "sbt-license-report"
enablePlugins(SbtPlugin)
libraryDependencies += lang3
scriptedLaunchOpts += s"-Dplugin.version=${version.value}"
pluginCrossBuild / sbtVersion := "1.9.5"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am just not sure if it's worth forcing the users to use latest sbt 1.9.6 for one plugin, if they want this plugin.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair point, I guess you could use reflection to see if the method already exists and if not default to the one from 1.9.5 however this is over-engineering is even more complicated than the current implementation.

I think its worth it to leave this PR open as there many be some future sbt change which is critical to this plugin at which point we can merge this PR.

On a similar note, there have been various security issues that have been fixed in more recent versions of sbt so I don't know if thats a strong enough argument to merge the PR since most users should be using a more recent version of sbt but I will leave this to your discretion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants