Update sbt and add windows back to CI #163
Conversation
mdedetrich
force-pushed
the
add-windows-back-to-ci
branch
6 times, most recently
from
a8071e7
to
4e30ea5
Compare
mdedetrich
force-pushed
the
add-windows-back-to-ci
branch
2 times, most recently
from
87a2d13
to
fd80d5b
Compare
build.sbt
Outdated
| @@ -51,7 +50,7 @@ ThisBuild / version := { | |||
| } | |||
|
|
|||
| sbtPlugin := true | |||
| pluginCrossBuild / sbtVersion := "1.5.5" | |||
| pluginCrossBuild / sbtVersion := "1.9.5" | |||
There was a problem hiding this comment.
So theoritically speaking I don't think you need to update this because afaik this sbt setting is mandating the minimum sbt version that the sbt-github-actions plugin needs to compile where as build.properties (which this PR adds/updates as neccessary) specifies the actual sbt version that is used at runtime when the scripted tests are being run. See sbt/sbt#7087 (comment) for more context
@eed3si9n Maybe you have a better idea what is going on here? I also think that updating pluginCrossBuild / sbtVersion can be problematic because you are essentially forcing the minimum sbt version on downstream consumers and this sbt plugin does not actually need such a new sbt version.
mdedetrich
force-pushed
the
add-windows-back-to-ci
branch
2 times, most recently
from
eb9afcf
to
1f62cad
Compare
mdedetrich
force-pushed
the
add-windows-back-to-ci
branch
from
1f62cad
to
921955e
Compare
mdedetrich
force-pushed
the
add-windows-back-to-ci
branch
from
921955e
to
70aa5c6
Compare
|
@eed3si9n Everything should be good now |
The latest version of sbt fixes the bug which caused scripted tests to not work on windows (see sbt/sbt#7087) so this PR updates to the latest sbt version and adds windows back to CI.
Resolves: #126