Modulable avro plugin #196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RustedBones
force-pushed
the
handle-multiple-versions
branch
2 times, most recently
from
f2ebb3d to
b76111f
Compare
RustedBones
changed the title
RustedBones
force-pushed
the
handle-multiple-versions
branch
from
e88e18e to
be074f4
Compare
kellen
reviewed
Oct 17, 2024
bridge/src/main/java/com/github/sbt/avro/AvroCompilerBridge.java
Outdated
Show resolved
Hide resolved
bridge/src/main/java/com/github/sbt/avro/AvroCompilerBridge.java
Outdated
Show resolved
Hide resolved
Comment on lines
135
to
148
| if (AvroVersion.getMinor() > 8) { | ||
| compiler.setGettersReturnOptional(optionalGetters); | ||
| } | ||
| if (AvroVersion.getMinor() > 9) { | ||
| compiler.setOptionalGettersForNullableFieldsOnly(optionalGetters); | ||
| } |
There was a problem hiding this comment.
Shouldn't the AvroVersion.getMinor ifs also check major version?
Also I suppose maintaining this bridge class means we need to track the avro API changes with each new version to correctly pass the new parameters. Is that right?
There was a problem hiding this comment.
yes. If there is a new compiler parameter, we can add it to the sbt plugin but we must make sure that if the runtime avro version does not support it, we won't call the method.
RustedBones
force-pushed
the
handle-multiple-versions
branch
3 times, most recently
from
7becea6 to
23e69a2
Compare
RustedBones
force-pushed
the
handle-multiple-versions
branch
from
23e69a2 to
51f6065
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
sbt-avrocan only use a single avro compiler version in the whole build.This PR intend to change this by using a custom
avroconfiguration, containing the required artifacts for the compilation phase.Other notable change: As the plugin now adds the
avrodependency, it is not automatically triggered.