-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add toString to UpdateOptions #6
Conversation
This class will likely be be generated by sbt-datatype eventually, and it'll regress even if I merge this. |
@eed3si9n Current sbt-datatype already generates |
cool, so if this going to be fixed in next version, feel free to close this PR |
Is this still an issue? @Duhemm says that |
that's what i see now with 0.13.15 > updateOptions
[info] sbt.UpdateOptions@bc690cbc
> sbtVersion
[info] 0.13.15
> |
@jozic We don't use sbt-datatype / contraband in 0.13. Also, it doesn't look like |
Along with finishing the remove sbinary/pickling we should finish migrating from case classes to contraband classes. |
Is that only concerning this module or all sbt modules? @dwijnand |
All of them. |
I don't see any issue merging this, particularly given it has a test. If/when it gets ported to by contraband generated, we can tweak the test that its toString is intelligible. |
This merged uncompilable code. |
as of 0.13.9 there is no an easy way to see updateOptions attributes
'[info] sbt.UpdateOptions@f5a7a399'