Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add toString to UpdateOptions #6

Merged
merged 1 commit into from
Jun 27, 2017
Merged

Conversation

jozic
Copy link
Contributor

@jozic jozic commented Sep 17, 2015

as of 0.13.9 there is no an easy way to see updateOptions attributes

'[info] sbt.UpdateOptions@f5a7a399'

@eed3si9n
Copy link
Member

This class will likely be be generated by sbt-datatype eventually, and it'll regress even if I merge this.
@Duhemm maybe we need to generate toString?

@Duhemm
Copy link
Contributor

Duhemm commented Sep 17, 2015

@eed3si9n Current sbt-datatype already generates toString for both Java and Scala

@jozic
Copy link
Contributor Author

jozic commented Sep 18, 2015

cool, so if this going to be fixed in next version, feel free to close this PR

@jvican
Copy link
Member

jvican commented Apr 26, 2017

Is this still an issue? @Duhemm says that toString is already generated by sbt-datatype.

@jozic
Copy link
Contributor Author

jozic commented Apr 27, 2017

that's what i see now with 0.13.15

> updateOptions
[info] sbt.UpdateOptions@bc690cbc
> sbtVersion
[info] 0.13.15
> 

@Duhemm
Copy link
Contributor

Duhemm commented Apr 27, 2017

@jozic We don't use sbt-datatype / contraband in 0.13.

Also, it doesn't look like UpdateOptions is generated in 1.0? I guess it's because of UpdateOptions.ResolverConverter.

@dwijnand
Copy link
Member

Along with finishing the remove sbinary/pickling we should finish migrating from case classes to contraband classes.

@jvican
Copy link
Member

jvican commented Apr 27, 2017

Is that only concerning this module or all sbt modules? @dwijnand

@dwijnand
Copy link
Member

All of them.

@dwijnand
Copy link
Member

I don't see any issue merging this, particularly given it has a test. If/when it gets ported to by contraband generated, we can tweak the test that its toString is intelligible.

@dwijnand dwijnand merged commit 7e87603 into sbt:1.0 Jun 27, 2017
@eed3si9n
Copy link
Member

This merged uncompilable code.

@eed3si9n eed3si9n mentioned this pull request Jun 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants