Avoid repeating versions in Eviction error message #386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather than seeing an error like this, with the evicted version numbers
being repeated many times:
```
[error] * org.scala-lang.modules:scala-java8-compat_2.13:1.0.0 (early-semver) is selected over {0.9.0, 0.9.0, 0.9.0, 0.9.0, 0.9.1, 0.9.1, 0.9.1}
```
...I'd much rather see an error like this:
```
[error] * org.scala-lang.modules:scala-java8-compat_2.13:1.0.0 (early-semver) is selected over {0.9.0, 0.9.1}
```
rtyley
force-pushed
the
avoid-repeating-version-in-eviction-error
branch
from
0bbe7d4
to
9786906
Compare
rtyley
added a commit
to rtyley/librarymanagement
that referenced
this pull request
Sep 16, 2023
As with sbt#386, which dealt with Eviction *errors*, this fixes the way Eviction *warnings* report the list of evicted versions - removing duplicate versions - and does a refactor so that both `EvictionError` & `EvictionWarning` are using the same logic to generate the revision string. The logic for the revisions string is moved to the new field `EvictionPair.evictedRevs`. Without this fix, we see Eviction warnings like this: ``` * org.scala-lang.modules:scala-java8-compat_2.13:1.0.2 is selected over {1.0.0, 1.0.0} ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the evicted version numbers can be repeated many times:
This change makes for a clearer message by removing that unnecessary noisy repetition:
Thanks!