define def config(...) as a macro to capture the Scala identifier #113
Conversation
|
Please, don't merge this. I'd like to review this PR soon and want to think a little bit about this change. |
|
Now that we've agreed on eventual adoption of slash syntax, can I merge this soon? |
|
I think this is good to go, sorry for blocking. I think enforcing this in the slash syntax is key for its well-functioning. |
| @@ -13,7 +13,7 @@ | |||
| { "name": "type", "type": "String", "default": "Artifact.DefaultType", "since": "0.0.1" }, | |||
| { "name": "extension", "type": "String", "default": "Artifact.DefaultExtension", "since": "0.0.1" }, | |||
| { "name": "classifier", "type": "Option[String]", "default": "None", "since": "0.0.1" }, | |||
| { "name": "configurations", "type": "sbt.librarymanagement.Configuration*", "default": "Vector.empty", "since": "0.0.1" }, | |||
| { "name": "configurations", "type": "String*", "default": "Vector.empty", "since": "0.0.1" }, | |||
There was a problem hiding this comment.
Please can we not make this change? This could be ConfigKey, or similar.
There was a problem hiding this comment.
Yea. I think it would be good to introduce ConfigRef in this PR.
| .callsiteTyper | ||
| .context | ||
| .enclosingContextChain | ||
| .map(_.tree.asInstanceOf[c.Tree]) |
There was a problem hiding this comment.
It's a shame to have this code copy-pasted from sbt's KeyMacro :-/
There was a problem hiding this comment.
Would you rather have me add util-lhs?
|
Rebased to 1.0 and added ConfigRef. |
| @@ -0,0 +1,46 @@ | |||
| /** | |||
| * This code is generated using [[http://www.scala-sbt.org/contraband/ sbt-contraband]]. | |||
There was a problem hiding this comment.
Why is this not in the contraband-scala directory?
| package librarymanagement | ||
|
|
||
| /** Represents an Ivy configuration. */ | ||
| final class Configuration private[sbt] ( |
There was a problem hiding this comment.
@dwijnand The ctor for Configuration is private.
|
Can we merge this so the review surface will be smaller for the API PR? |
In preparation to forward porting sbt/sbt#3255, this changes the implementation of
def config(name: String)so it captures the LHS as theidfield in Configuration.The constructor now enforces that the
id(the Scala identifier for val) starts with upper case, likeCompileandTest.sbt/sbt#2890