-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support of macOS arm64 #11
Conversation
This is great. I knew that the apple silicon was likely to cause problems for us. Thanks for building the binary. I don't think the logic for selecting the arch works on all platforms, which is why CI failed. That should be straightforward to fix. Were you actually able to get sbt to startup after this change on your computer? Naively I wouldn't expect this to be enough to get sbt working on apple silicon because the server uses the JNA implementation of ipcsocket by default. We could change the default to be JNI though. I'd love to get this released soon so that we could get a nightly version of sbt out that uses jni by default that you could test on your machine. |
@eatkins I made one more attempt. Honestly the first push was to see how CI is failed. Now it should be better. Much better. And yes, feel free to ping me as soon as you need my assisten to test night build on real machine. |
Would you mind pasting the command that you ran to build the binary? |
I run |
Perfect. Thanks. |
It is funny but `System.getProperty("os.arch")` returns `aarch64`.
Renamed |
see sbt/sbt#6165 |
We may want to revert this in favor of creating a universal binary: https://developer.apple.com/documentation/xcode/building_a_universal_macos_binary. |
@eatkins but universal binary exists only at macos :) |
Right, but at the moment we don't care about other platforms for JNI. We only use JNI for platforms that can't support JNA for whatever reason. |
This PR introduced a support of macOS arm64, and open a door to add support another non
x86_64
platforms.It contains two commits:
arch
to dynamic one,A
.dylib
looks like:Also it fixes #10 and covers sbt/sbt#6162