Add helper methods to create mappings #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- directory: create mappings from a baseDirectory including the baseDirectory - contentOf: create mappings from a baseDirectory excluding the baseDirectory
dwijnand
requested changes
Mar 2, 2017
io/src/main/scala/sbt/io/Path.scala
Outdated
| * @example Add a static directory "extra" and re-map the destination to a different path | ||
| * {{{ | ||
| * mappings in Universal ++= contentOf(baseDirectory.value / "extra").map { | ||
| * case (src, destination => src -> s"new/path/$destination" |
There was a problem hiding this comment.
this example doesn't compile (missing )) and is missing an explanation at the end.
io/src/main/scala/sbt/io/Path.scala
Outdated
| * File(extras/file1) -> "extras/file1" | ||
| * File(extras/file2) -> "extras/"file2" | ||
| * ... | ||
| * }}} |
There was a problem hiding this comment.
This example seems to be wrong. I'm getting:
scala> for ((file, path) <- Path directory (file("base") / "extra")) println(s"""$file -> "$path"""")
base/extra -> "extra"
base/extra/file1 -> "extra/file1"
base/extra/file2 -> "extra/file2"
io/src/main/scala/sbt/io/Path.scala
Outdated
| * File(extras/file1) -> "file1" | ||
| * File(extras/file2) -> "file2" | ||
| * ... | ||
| * }}} |
There was a problem hiding this comment.
This example seems to be wrong. I'm getting:
scala> for ((file, path) <- Path contentOf (file("base") / "extra")) println(s"""$file -> "$path"""")
base/extra/file1 -> "file1"
base/extra/file2 -> "file2"
|
@dwijnand What's the status on this PR? |
dwijnand
reviewed
Mar 18, 2017
| * File($baseDirectory/extras/file1) -> "extras/file1" | ||
| * File($baseDirectory/extras/file2) -> "extras/"file2" | ||
| * ... | ||
| * }}} |
There was a problem hiding this comment.
Isn't this still missing $baseDirectory/extra -> "extra"?
| * | ||
| * {{{ | ||
| * File($baseDirectory/extras/file1) -> "extras/file1" | ||
| * File($baseDirectory/extras/file2) -> "extras/"file2" |
| * @example Add a static directory "extra" and re-map the destination to a different path | ||
| * {{{ | ||
| * mappings ++= contentOf(baseDirectory.value / "extra").map { | ||
| * case (src, destination => src -> s"new/path/$destination" |
|
I just submitted the review that I had pending from 2 weeks ago.. Haven't reviewed the latest 2 commits. |
muuki88
force-pushed
the
add-mapping-helpers
branch
from
dbe6eab to
2b184f0
Compare
|
Sorry for the long standing PR. Finally got time to clean this up |
eed3si9n
approved these changes
Mar 27, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I put this on the
Pathobject. Not sure if this is a good place.The test aren't property based. I probably need to add some corner cases like
baseDirectorybaseDirectoryis a filebaseDirectory