Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump JNA to 5.8.0 #321

Merged
merged 1 commit into from
Jul 19, 2021
Merged

Bump JNA to 5.8.0 #321

merged 1 commit into from
Jul 19, 2021

Conversation

vbabenkoru
Copy link
Contributor

Fixes #320

@vbabenkoru
Copy link
Contributor Author

@eed3si9n Thanks! Are you planning to merge this for the next release?

@eed3si9n
Copy link
Member

Note that 1.5.x series is already branched out to 1.5.x, so merging this to develop branch doesn't necessarily mean it will be part of the next release. I am not sure how safe it would be to upgrade JNA without going through RC cycle. It might address this issue, but it could break some other plugin?
sbt transitively also depend on JNA via sbt/ipcsocket, and I've actually released ipcsocket 1.3.1 and ipcsocket 1.4.0 so I don't introduce JNA upgrade in 1.5.x. One potential workaround might be to release sbt 1.6.0-M1 or fix the nightly build.

@eed3si9n eed3si9n merged commit 02a0cfa into sbt:develop Jul 19, 2021
@mkurz mkurz mentioned this pull request Jul 27, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eed3si9n eed3si9n eed3si9n approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update JNA library for compatibility with Apple M1 + io.methvin:directory-watcher
2 participants
@vbabenkoru @eed3si9n