Add sleep to user input thread #149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I didn't realize that System.in.read is not interruptible, so it was problematic* to change the downstream termination condition from: - System.in.available > 0 && (watched.terminateWatch(System.in.read()) || shouldTerminate) + watched.terminateWatch(System.in.read()) || shouldTerminate Instead, we should revert to the old termination condition and add a sleep so that we don't peg the cpu. * This would manifest as the user having to hit enter twice to exit the watch in some circumstances because the user input thread could not be joined.
This was referenced May 8, 2018
eed3si9n
approved these changes
May 8, 2018
|
ok. A new version of IO coming up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I didn't realize that System.in.read is not interruptible, so it was
problematic* to change the downstream termination condition from:
Instead, we should revert to the old termination condition and add a
sleep so that we don't peg the cpu.
watch in some circumstances because the user input thread could not be
joined.