align exception from file-timestamp functions from different impl. #121
Conversation
|
@dwijnand done, this pr is on top of 1.1.x |
| try { | ||
| f | ||
| } catch { | ||
| case e: NoSuchFileException => throw new FileNotFoundException(e.getFile) |
There was a problem hiding this comment.
An issue here is that the original stack trace is lost. It is not a big problem since mapNoSuchFileException() is only used once, but if it were used from more than one method, it would not be clear which code path led to the exception. Normally that can be avoided by chaining exceptions; however, it just so happens that FileNotFoundException does not have a Throwable-based constructor, so chaining is a bit more difficult than usual. Still, there is a workaround:
case e: NoSuchFileException => throw new FileNotFoundException(e.getFile) {
initCause(e)
override def toString() = {
val msg = getLocalizedMessage()
getClass().getSuperclass().getName() + (if (msg == null) "" else (": " + msg))
}
}
This will be reported as:
java.io.FileNotFoundException: filename
at ...
Caused by: java.nio.file.NoSuchFileException: filename
at ...
Where the second exception identifies the original stacktrace. The additional toString() is needed in order to keep the exception identifying itself as a FileNotFoundException in the printout.
There was a problem hiding this comment.
I think you can just call initCause.
There was a problem hiding this comment.
thanks for your suggestions.
yes, throw new FileNotFoundException(e.getFile).initCause(e) preserves the stacktrace - thanks:
[error] java.io.FileNotFoundException: /nothing
[error] at sbt.internal.io.JavaMilli$.mapNoSuchFileException(Milli.scala:334)
[error] at sbt.internal.io.JavaMilli$.getModifiedTime(Milli.scala:322)
[error] at sbt.internal.io.Milli$.getModifiedTime(Milli.scala:362)
[error] at sbt.io.IO$.getModifiedTime(IO.scala:1143)
...
[error] Caused by: java.nio.file.NoSuchFileException: /nothing
[error] at sun.nio.fs.UnixException.translateToIOException(UnixException.java:86)
[error] at sun.nio.fs.UnixException.rethrowAsIOException(UnixException.java:102)
[error] at sun.nio.fs.UnixException.rethrowAsIOException(UnixException.java:107)
...
should i make this change in a new commit, or amend the actual commit?
* The native implementations to get / set a file-timestamp throws a 'java.io.FileNotFoundException' where the Java based implementation throws a 'java.nio.file.NoSuchFileException' if the given file does not exists. * 'IO.getModifiedTimeOrZero' and 'IO.setModifiedTimeOrFalse' handles only 'java.io.FileNotFoundException' * Map 'NoSuchFileExeption' to 'FileNotFoundException' in the Java based implementation, so all implementations throws the same error.
|
done |
|
Thanks, @j-keck. |
The native implementations to get / set a file-timestamp throws
a 'java.io.FileNotFoundException' where the Java based implementation
throws a 'java.nio.file.NoSuchFileException' if the given file
does not exists.
'IO.getModifiedTimeOrZero' and 'IO.setModifiedTimeOrFalse' handles
only 'java.io.FileNotFoundException'
Map 'NoSuchFileExeption' to 'FileNotFoundException' in the
Java based implementation, so all implementations throws
the same error.
fixes sbt/sbt/issues/3894