Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Plugin executes out of order relative to other serverless plugins #18

Open
jhslinkman opened this issue Sep 6, 2018 · 2 comments
Open

Plugin executes out of order relative to other serverless plugins #18

jhslinkman opened this issue Sep 6, 2018 · 2 comments

Comments

@jhslinkman
Copy link

Consider a serverless.yml

...
plugins:
    - serverless-stack-ouput
    - other-plugin

custom:
  output:
    file: stack-output.yml
...

where other-plugin processes stack-output.yml output by this file. As it's currently implemented, other-plugin will being processing before serverless-stack-output finished. The offending line is in the StackOutputPlugin#process method. If that method is changed to return a promise, everything works as expected.
jhslinkman pushed a commit to jhslinkman/serverless-stack-output that referenced this issue Sep 6, 2018
[sbstjn#18] StackOutputPlugin#process now returns a promise
fd3a55b 
This allows this plugin to execute in the order in which it is included
in the plugins section of serverless.yml
@jhslinkman jhslinkman mentioned this issue Sep 6, 2018
Open
kevinsperrine added a commit to kevinsperrine/serverless-stack-output that referenced this issue Dec 6, 2018
@kevinsperrine
wait until handler is finished before resolving promise
5e26ebf 
Related to sbstjn#18 and sbstjn#19. Then waits until the handlers have finished before resolving the promise.
@kevinsperrine kevinsperrine mentioned this issue Dec 6, 2018
Closed
@anttiviljami anttiviljami mentioned this issue Dec 16, 2018
Open
@anttiviljami
Copy link

anttiviljami commented Dec 16, 2018 •
edited
Loading

Since the original package doesn't seem to be maintained. I've merged #17 + #19 and published on npm under @anttiviljami/serverless-stack-output

@ismarslomic
Copy link

Any chance this can be merged to this original package?

@anttiviljami anttiviljami mentioned this issue May 3, 2019
Open
This was referenced May 1, 2020
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ismarslomic @jhslinkman @anttiviljami