Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable device names #212

Closed
ceskyDJ opened this issue Apr 21, 2021 · 4 comments
Closed

Configurable device names #212

ceskyDJ opened this issue Apr 21, 2021 · 4 comments
Assignees
Milestone

Comments

@ceskyDJ
Copy link
Contributor

ceskyDJ commented Apr 21, 2021

Hi, your app shows devices as there addresses. It's really good for accurate identification but it's not too nice for quick-reading and selecting the right device. "Blue scanner in Ben's room" is always better than "hpaio:/net/Printer_Model_Name_series?ip=192.168.11.31&queue=false", isn't it?

There is one main problem - where to edit the names. Devices are stored in config files - can I change the name without problems? It could be the solution :D.

@sbs20
Copy link
Owner

sbs20 commented Apr 22, 2021

The device name is needed in order to execute a scan (certainly with multiple scanners). So it's not possible just to change the name. The only solution I can think of is to allow users to create their own map of deviceids to names:

config.deviceNames = {
  'hpaio:/net/Printer_Model_Name_series?ip=192.168.11.31&queue=false': 'Blue scanner in Ben's room',
  'net:10.0.7.129:airscan:e0:Canon TR8500 series-5': 'Green scanner in the corner'
};

That could then get sent to the UI and it could do the rest.

But this would be susceptible to scanner device id changes (IP address / USB port). Or you could make it do a regex match, but then that's getting even more complicated.

I'm happy to leave this issue open for a while to see if there's other interest, but I'm not convinced it's worth the effort given that the solution still wouldn't be great and I'm not convinced this would be widely used.

@xxjkzs
Copy link
Contributor

xxjkzs commented May 16, 2021

I would vote yes for this feature. Especially when the devices are all the same brand or even same model.
Not everyone knows what those long string means besides the one who set them up. If they have problems, users won't read that weird string to debug themselves anyway. It's better to make the users easier to tell which machine they are using.

@sbs20 sbs20 added this to the v2.13.0 milestone May 17, 2021
@sbs20 sbs20 self-assigned this May 17, 2021
sbs20 added a commit that referenced this issue May 17, 2021
@sbs20 sbs20 added dev and removed open to votes labels May 17, 2021
@sbs20 sbs20 changed the title FEATURE REQUEST: Configurable device names Configurable device names May 18, 2021
@sbs20 sbs20 added the staging label May 18, 2021
@sbs20 sbs20 closed this as completed May 18, 2021
@sbs20
Copy link
Owner

sbs20 commented May 18, 2021

@ceskyDJ
Copy link
Contributor Author

ceskyDJ commented May 18, 2021

Thanks a lot for adding this feature!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants