Sort items in people view #670
Conversation
AlexPerathoner
force-pushed
the
dev
branch
4 times, most recently
from
ef683c9
to
a9ed5d4
Compare
There was a problem hiding this comment.
Hi @AlexPerathoner, thank you for taking the time to do this!
I noticed one bug with the sorting and one small thing I think we could improve upon (we could possibly be using just one list instead of two for storing the credits).
Let me know if I can help with anything (or if you want me to finish any of this)!
AlexPerathoner
force-pushed
the
dev
branch
2 times, most recently
from
2ac4155
to
92d334f
Compare
|
Removed the two cached arrays into just one; updated methods to reflect that; updated sort method to treat shows which don't have a release date nor a first air date as unreleased (so they appear first when sorting by Newest and last when by Oldest). Also noticed that some people have duplicate items in them (because of different |
… .container - Removed min-width so improve responsivity for mobile (overflows). - Removed unused styles (margin-top/bottom that were overridden in .container). - Add max-width to match PosterList. - Remove .container and add styles to .filters (combined them).
No need for the filter when this is true, we can just pass the options var.
…credits array directly I believe this should be more performant (removing the use of spread operator) and is just a little cleaner.
Relates to #619
Changes made
Added sort dropdown to sort items in
/person/[id]views by Vote count (former method), oldest / newest release date