Skip to content

Commit

Permalink
Fix CloudFormation cross-region changeset approval
Browse files Browse the repository at this point in the history
**Why?**

With the CloudFormation deployment provider: It would fail to create the
pipeline if one were to set the `change_set_approval` property to `True`,
while the pipeline lives in another region than where it is asked to deploy to.

**What?**

* The approval action should be performed in the region that hosts the
  pipeline. Not the target region.
  • Loading branch information
sbkok committed Mar 28, 2024
1 parent 7a4359f commit 294d476
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ def generate_actions(targets, region, map_params, target_approval_mode):
name=f"{target['name']}-{region}",
provider="Manual",
category="Approval",
region=region,
region=ADF_DEPLOYMENT_REGION,
target=target,
run_order=2,
map_params=map_params,
Expand Down

0 comments on commit 294d476

Please sign in to comment.