New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make BroadcastProtocol's type assert typecheck time only #95

Merged

sbidy merged 1 commit into sbidy:master from akx:no-runtime-isinstance

Dec 17, 2021

Contributor

akx commented Dec 17, 2021 •

edited

Loading

TYPE_CHECKING is never true at runtime, so the assertion won't be triggered, but Mypy will be happy nevertheless.

Should fix #94


          Make BroadcastProtocol's type assert typecheck time only

653dbb2

Should fix sbidy#94

akx mentioned this pull request

AssertionError in pywizlight.discovery #94

Closed

Contributor Author

akx commented Dec 17, 2021

Still some issues with the lints, it seems... 🙄 Maybe ${{ secrets.github_token }} needs to be ${{ secrets.GITHUB_TOKEN }}?

sbidy merged commit 762af30 into sbidy:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet