Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure late arriving messages from previous requests are ignored #136

Merged
merged 1 commit into from
Feb 21, 2022

Conversation

bdraco
Copy link
Contributor

@bdraco bdraco commented Feb 21, 2022

Fixes #135

@bdraco bdraco marked this pull request as draft February 21, 2022 00:36
@codecov-commenter
Copy link

codecov-commenter commented Feb 21, 2022

Codecov Report

Merging #136 (1732c97) into master (3199eb5) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #136      +/-   ##
==========================================
+ Coverage   89.39%   89.41%   +0.01%     
==========================================
  Files          12       12              
  Lines         858      869      +11     
==========================================
+ Hits          767      777      +10     
- Misses         91       92       +1     
Impacted Files Coverage Δ
pywizlight/bulb.py 90.49% <100.00%> (+0.01%) ⬆️
pywizlight/push_manager.py 98.80% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3199eb5...1732c97. Read the comment docs.

@bdraco bdraco force-pushed the ignore_late_arriving_messages branch 6 times, most recently from 78d7858 to 3a39a6a Compare February 21, 2022 01:00
@bdraco bdraco marked this pull request as ready for review February 21, 2022 01:04
@bdraco bdraco force-pushed the ignore_late_arriving_messages branch from 3a39a6a to 5fd467a Compare February 21, 2022 01:33
@bdraco bdraco force-pushed the ignore_late_arriving_messages branch from 5fd467a to 1732c97 Compare February 21, 2022 01:35
@sbidy sbidy merged commit f7fad08 into sbidy:master Feb 21, 2022
@bdraco
Copy link
Contributor Author

bdraco commented Feb 21, 2022

This one should probably get another release since its pretty easy to replicate when the firmware is updating on a newly setup bulb which leads to the config flow discovery being aborted if it happens to not reply on the first request when its out of box firmware doesn't support getModelConfig

@bdraco
Copy link
Contributor Author

bdraco commented Feb 21, 2022

Looks like you already pushed .12 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

If a request is retried, the response may arrive after the next message is sent
3 participants