-
-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for discovering new devices via broadcast of their first heartbeat #111
Conversation
e6662e8
to
8488b71
Compare
The descriptions may be too specific as I think the models are a bit more generic |
1aa17bf
to
b0b6ff6
Compare
Codecov Report
@@ Coverage Diff @@
## master #111 +/- ##
===========================================
+ Coverage 29.59% 74.08% +44.49%
===========================================
Files 13 12 -1
Lines 821 741 -80
===========================================
+ Hits 243 549 +306
+ Misses 578 192 -386
Continue to review full report at Codecov.
|
ee3ac82
to
114a07c
Compare
So I don't think this actually gives enough info to identify the device |
b2ba620
to
326adaf
Compare
efd11ad
to
c24c771
Compare
c24c771
to
b788440
Compare
Yes, thats true. I don't see a chance to have such a generic approach with the info we got from the UDP interface. Maybe we got a new property for a possible detection of the physical shape of the bulb/stripe/etc.. Thank you for jumping in and having a second look into that. |
Adds
set_discovery_callback
which will immediately discover devices when they boot up when push updates are active.Devices broadcast a
firstBeat
udp packet on boot with their mac address which allows us to discover new devices, and update the ip address we have for the device to avoid having to wait for the next discovery.Adds white channels and white to color ratio from bulb config. The data described in Comment: Determining Bulb Kind #77 seems to be a lot more generic and its actually the number of white channels and white to color ratio.
Closes Comment: Determining Bulb Kind #77
Various refactoring and tests to increase test coverage
Remove
connect_on_init
as it did blocking I/O which would stall the event loop